pr-approval-check: refactor, fix pagination, fix approval logic #4519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
localsource
approved these changes
Oct 28, 2025
j2fw
force-pushed
the
jw/check-product-eng-approval-update
branch
from
8e13834 to
77fa7d1
Compare
j2fw
changed the title
j2fw
changed the title
j2fw
force-pushed
the
jw/check-product-eng-approval-update
branch
from
c1a9c26 to
fa6ad1b
Compare
j2fw
commented
Oct 29, 2025
dustin-decker
approved these changes
Oct 29, 2025
j2fw
merged commit f0df738
into
cursor/require-product-eng-approval-for-prs-f38f
11 of 13 checks passed
dustin-decker
added a commit
that referenced
this pull request
Oct 30, 2025
* feat: Add PR approval check for product-eng team Co-authored-by: dustin <[email protected]> * Checkpoint before follow-up message Co-authored-by: dustin <[email protected]> * Refactor: Expand PR approval to include child teams Co-authored-by: dustin <[email protected]> * poke * pr-approval-check: refactor, fix pagination, fix approval logic (#4519) * Update README.md * use secret --------- Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Jeff W <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the
pr-approval-checkworkflow with some different logic:🗒️ Note: we may need to update github token privileges
Checklist:
make test-community)?make lintthis requires golangci-lint)?