feat: index jlcpcb basic parts #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
requested changes
Sep 13, 2025
seveibar
reviewed
Sep 13, 2025
| expect(typeof c.lcsc).toBe("number") | ||
| if ("key" in c) { | ||
| expect(typeof c.key).toBe("string") | ||
| } |
There was a problem hiding this comment.
NEVER HAVE CONDITIONAL ASSERTIONS IN TESTS!
seveibar
reviewed
Sep 13, 2025
| const components = fullComponents.map((c) => ({ | ||
| const fullWithBasic = fullComponents.map((c) => { | ||
| const { basic, ...rest } = c | ||
| return { ...rest, is_basic_part: basic === 1 } |
There was a problem hiding this comment.
you need to set is_basic_part in the database like all the other properties, not remap
seveibar
reviewed
Sep 13, 2025
| ? null | ||
| : { | ||
| ...c, | ||
| is_basic_part: components[i].basic === 1, |
There was a problem hiding this comment.
why is this property special? Don't remap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref github.com/tscircuit/tscircuit/issues/781