Skip to content

Conversation

@seveibar
Copy link
Contributor

Summary

  • propagate numeric pin numbers to pcb_smtpad and pcb_plated_hole elements when port names are numeric
  • verify plated holes keep pin numbers and add a new SMD footprint regression covering pin_number on pads
  • include a simple SMD footprint fixture for reuse in tests

Testing

  • bunx tsc --noEmit
  • bun test tests/repros/repro02-promicro-port-hints.test.ts
  • bun test tests/repros/repro03-smt-pin-number.test.ts
  • bun run format

Codex Task

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
kicad-component-converter Ready Ready Preview Comment Nov 20, 2025 5:03am

@seveibar seveibar merged commit 6108d45 into main Nov 20, 2025
5 checks passed
@seveibar seveibar deleted the codex/verify-port_hints-and-pin_numbers-in-kicad_mod branch November 20, 2025 05:44
@seveibar
Copy link
Contributor Author

CC @techmannih can you help me get this fix upstream and confirm that users importing the kicad_mod file that itsme had on discord (committed in this PR as pro_micro.kicad_mod) works with tsci dev when you try to reference the pin numbers? See discord thread for details: https://discord.com/channels/1233487248129921135/1440878142473634002/1440886651336265738

@tscircuitbot
Copy link


Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


@techmannih
Copy link
Member

Yes, sure I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants