fix: layer order of silkscreen #452
Conversation
imrishabh18
requested review from
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ), | ||
| foregroundLayer, |
There was a problem hiding this comment.
When the foreground layer is top or bottom, layersToShiftToTop still filters out the associated silkscreen layer, but the reordered array here only re‑adds foregroundLayer and "drill". That means the filtered silkscreen canvas is never assigned a new z-index or opacity, so it stays at its previous default (typically below all other layers) and disappears from view instead of being layered and faded with its copper side. The silkscreen needs to be reinserted into order or left out of the filter so that it remains visible when highlighting a side.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.