Skip to content

Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Test using the .NET 6 SDK and stop adding a duplicate compile item for WPF #90

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bfae1d3
Move to current SDK
jnm2 Nov 21, 2021
7c407af
Use non-EOL target frameworks to avoid NETSDK1138
jnm2 Nov 21, 2021
78bc1e4
Fix nullability warnings due to updated BCL annotations
jnm2 Nov 21, 2021
7ce2960
[research needed]
jnm2 Nov 21, 2021
60f74bd
Test default SDK behavior pre-6 as well
jnm2 Nov 21, 2021
c43ce21
SDK now includes net35 reference assemblies (AppVeyor image doesn't h…
jnm2 Nov 21, 2021
b96bda9
Fix net35 "MC1000: Unknown build error, 'Known type value 275='IAddCh…
jnm2 Nov 21, 2021
3949c76
Remove unnecessary namespaces
jnm2 Nov 21, 2021
a070e10
Fix duplicate compile item being added in wpftmp project
jnm2 Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ionLabs.ReferenceAssemblyAnnotator/EquivalenceComparers+ArrayDimensionEqualityComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ private ArrayDimensionEqualityComparer()
{
}

#pragma warning disable CS8614 // In CLI builds: Nullability of reference types in type of parameter 'x' of 'bool ArrayDimensionEqualityComparer.Equals(ArrayDimension x, ArrayDimension y)' doesn't match implicitly implemented member 'bool IEqualityComparer<ArrayDimension>.Equals(ArrayDimension x, ArrayDimension y)'.
public bool Equals(ArrayDimension x, ArrayDimension y)
Comment on lines +19 to 20
Copy link
Contributor Author

@jnm2 jnm2 Nov 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell ArrayDimension is a struct coming from the Mono.Cecil package. This issue doesn't repro unless RAA is rewriting reference assemblies.

Not sure if this is an existing RAA problem when used normally or whether it's a regression introduced in this PR.

#pragma warning restore CS8614
{
return x.LowerBound == y.LowerBound
&& x.UpperBound == y.UpperBound;
Expand Down