Do not explore beyond rule stop states when computing possible next tokens during error recovery #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okens during error recovery Fixes tunnelvisionlabs#84
|
Note this aligns with the implementation of https://github.com/antlr/antlr4/blob/v4.11.1/runtime/Java/src/org/antlr/v4/runtime/atn/LL1Analyzer.java#L186 Running performance tests against java.lang classes directory shows no impact to the execution time. |
|
@sharwell can you review when you have a chance? If this optimized fork is still maintained. After merging I will port to the Typescript and C# optimized fork targets as well. |
I'm afraid it's not. |
|
@br0nstein LGTM, so I merged your PR into my fork[1] and released 4.13.1.1, which will be used by Apache Groovy[2]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84