- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.7k
feat(character-count): default editor getText count #7071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            trinketmage
  wants to merge
  8
  commits into
  ueberdosis:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
trinketmage:develop
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +14
        
        
          −9
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 🦋 Changeset detectedLatest commit: bfc9589 The changes in this PR will be included in the next version bump. This PR includes changesets to release 70 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| ✅ Deploy Preview for tiptap-embed ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
      
  
  Open
  
      
        
      
      
  
    1 task
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Changes Overview
Closes #5777
Instead of
Node.textBetween(), ifoptions.nodeis not set, usesthis.editor.getText()to count full text from "descendant" nodes.Implementation Approach
Using
getText()seems to dogetTextBetween()on node, as we need on theeditorfeat: add getText() and generateText() methods (fix #1428)The key difference is that in current
CharacterCount,optionspassed tonode.textBetween()areoptions=undefined, then there is nooptions.textSerializers:But inside getText(),
options.textSerializersis defined through theschema, and, passed correctly to thegetTextBetween():Testing Done
Instead of counting
1 characterfor a "Mention", it now counts the current length with the prefix character that is by default@and the actual length of thenameby default in the example12.Verification Steps
Check those pages:
http://localhost:3000/src/Examples/Community/Vue/
http://localhost:3000/src/Examples/Community/React/
Add
CharacterCountto this page:http://localhost:3000/preview/Nodes/Mention
Additional Notes
Checklist
Related Issues
#5777