Skip to content

Conversation

@somonek
Copy link

@somonek somonek commented Oct 29, 2025

Allow setting a different classname per node type in case of complex documents with multiple placeholders, by using a function as emptyNodeClass option for placeholder extension.

Changes Overview

Added option to pass a function to emptyNodeClass

Implementation Approach

Added option to pass a function to emptyNodeClass

Testing Done

Manual testing done

Verification Steps

Pass a function to emptyNodeClass instead of a string, and different classnames per different node types

Additional Notes

NA

Doc update

ueberdosis/tiptap-docs#475

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

NA

…pe in case of complex documents with multiple placeholders
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: a3783f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit a3783f8
🔍 Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/690203569a43540008b6d064
😎 Deploy Preview https://deploy-preview-7140--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@somonek somonek changed the title fix(placeholder-ext): Allow emptyNodeClass take a function fix(extensions/placeholder): Allow emptyNodeClass take a function Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant