fix: correct input_size_total calculation in VariableSelectionNetwork. #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly calculate total input size by using hidden_size for embedded variables and original size for non-embedded variables. Fixes unit8co#2817
Update changelog to reference correct pull request ID for VariableSelectionNetwork input_size_total bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly calculate total input size by using hidden_size for embedded variables and original size for non-embedded variables.
Checklist before merging this PR:
Fixes #2817 .
Summary
Fixed a bug in the
input_size_totalproperty of_VariableSelectionNetworkwhere the conditional expressionsize if name in self.input_embedding_flags else sizewas always returningsizeregardless of the condition.The corrected implementation now properly calculates the total input size by:
hidden_sizefor embedded (categorical) variablessizefor non-embedded (continuous) variablesOther Information
This bug would have caused incorrect tensor dimensions when mixing embedded and non-embedded variables, potentially leading to runtime errors.