Skip to content

Conversation

@tRosenflanz
Copy link
Contributor

Fixes #2843

Summary

Simple improvement to consider parameters of the full class inheritance of the checked class instead of specific classes for TorchForecastingModel

@codecov
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.29%. Comparing base (cf3a396) to head (c4dd9f4).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...arts/models/forecasting/torch_forecasting_model.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
- Coverage   95.38%   95.29%   -0.09%     
==========================================
  Files         146      146              
  Lines       15628    15638      +10     
==========================================
- Hits        14907    14903       -4     
- Misses        721      735      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tRosenflanz
Copy link
Contributor Author

Do you want me to add a test for this? I can use the example from the original issue for it

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tRosenflanz and thanks a lot for the PR 🚀

Yes, a unit test would be great :) Could you also:

  • try to improve the code coverage with the new tests (from the codecov comment above).
  • add an entry to CHANGELOG.md describing your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modified parameter validation to support better subclassing

2 participants