-
Notifications
You must be signed in to change notification settings - Fork 973
Migrated .plot() from using xarray #2932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated .plot() from using xarray #2932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks a lot @jakubchlapek 😍 🚀
Co-authored-by: Dennis Bader <[email protected]>
Co-authored-by: Dennis Bader <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2932 +/- ##
==========================================
+ Coverage 95.40% 95.45% +0.05%
==========================================
Files 146 146
Lines 15701 15703 +2
==========================================
+ Hits 14979 14989 +10
+ Misses 722 714 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added some unit tests for |
Checklist before merging this PR:
Summary
Changed Timeseries.plot() implementation to no longer rely on xarray under the hood while keeping same functionality.