Upstream changes #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent crash if camerBuffer is empty on error
- fix binding context on serialconnection events - comment out start in startSerial because it is called in constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes for binding contexts and a fix for the serial controller double starting. This will prevent Access Denied on Windows and possibly other issues on other platforms.
Also implemented a work around for preventing the library crashing when the cameraBuffer is empty on error in Camera. This seems like a bad idea because why is the cameraBuffer empty? Basically ignores the error. Need to figure out why the cameraBuffer is empty to handle this properly.