Skip to content

fix docs hashsumS and test #7936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

fix docs hashsumS and test #7936

wants to merge 20 commits into from
+210 −17

Conversation

@Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented May 15, 2025

Fixing the mdbook docs for

@Its-Just-Nans Its-Just-Nans changed the title fix docs hashsum fix docs hashsumS and test May 15, 2025
@Its-Just-Nans Its-Just-Nans mentioned this pull request May 15, 2025
Open
17 tasks
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented May 15, 2025

Hi

With #7936

Usage: target/debug/coreutils md5sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha1sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha224sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha256sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha384sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha512sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha3sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha3-224sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha3-256sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha3-384sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils sha3-512sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils shake128sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils shake256sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils b2sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils b3sum [OPTIONS]... [FILE]...
Usage: target/debug/coreutils hashsum --<digest> [OPTIONS]... [FILE]...

@github-actions
Copy link

github-actions bot commented May 15, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

BenWiederhake
BenWiederhake reviewed May 17, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 19, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented May 19, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@RenjiSann
Copy link
Collaborator

RenjiSann commented May 22, 2025

Can the testsuite currently test these behaviors @sylvestre ?

@sylvestre
Copy link
Contributor

sylvestre commented May 25, 2025

@Its-Just-Nans yeah, maybe add tests for this to make sure we don't regress? thanks

@RenjiSann dunno, sorry :)

@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented May 25, 2025

@Its-Just-Nans yeah, maybe add tests for this to make sure we don't regress? thanks

done

@Its-Just-Nans Its-Just-Nans requested a review from sylvestre May 25, 2025 23:20
@github-actions
Copy link

github-actions bot commented May 25, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Nov 9, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Its-Just-Nans
Its-Just-Nans commented Nov 10, 2025
View reviewed changes
Its-Just-Nans
Its-Just-Nans commented Nov 10, 2025
View reviewed changes
src/bin/uudoc.rs
validation::setup_localization_or_exit(utility);
let mut cmd = util_map.get(utility).unwrap().1();
cmd.set_bin_name(utility.clone());
let mut cmd = cmd.display_name(utility);
Copy link
Contributor Author

@Its-Just-Nans Its-Just-Nans Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important fix because - if not present - the manpage will have the uudoc name

Copy link
Contributor

@oech3 oech3 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayelkin Is it able to split PR from this PR or close #9152 ?

Copy link

@shayelkin shayelkin Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would solve the same issue.

I'm biased of course, but I like my PR better asit keeps the command-naming codepath the same in uudoc and the coreutils binary, and update the tests to catch if the issue regressing, but those are really nits: I can either rebase on top of this or close it – your call.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Nov 10, 2025 •
edited
Loading

@sylvestre I think now it's ready

Note that it seems that some binaries where missing in build.rs
If it's a mistake to add them, the test_uudocs.rs should be updated accordingly

@oech3
Copy link
Contributor

oech3 commented Nov 19, 2025

#7936 (comment) Non GNU binary names are dropped.

@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Nov 19, 2025

#7936 (comment) Non GNU binary names are dropped.

Thanks you, make sense.

Fixed the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWiederhake BenWiederhake Awaiting requested review from BenWiederhake

@sylvestre sylvestre Awaiting requested review from sylvestre

2 more reviewers

@shayelkin shayelkin shayelkin left review comments

@oech3 oech3 oech3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Its-Just-Nans @RenjiSann @sylvestre @oech3 @shayelkin @BenWiederhake