-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
mv: support moving folder containing symlinks to different filesystem #8605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mv: support moving folder containing symlinks to different filesystem #8605
Conversation
55ba4db to
ef80a6d
Compare
|
GNU testsuite comparison: |
ef80a6d to
20d8165
Compare
|
GNU testsuite comparison: |
20d8165 to
02cca37
Compare
|
GNU testsuite comparison: |
tests/by-util/test_mv.rs
Outdated
| } | ||
|
|
||
| #[cfg(all(unix, not(target_os = "android")))] | ||
| #[ignore = "requires sudo"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the ignore
we do run some tests as root in the ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to make the tests work. Do you mind take a look at the error outputs and provide suggestions? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sudo executable is not available in the test. Even a simple sudo ls would fail:
run: sudo -E --non-interactive ls
thread 'test_mv::test_mv_broken_symlink_to_another_fs' panicked at tests/uutests/src/lib/util.rs:1976:37:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
https://github.com/uutils/coreutils/actions/runs/18166245128/job/51709489403?pr=8605#step:14:4625
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux have /tmp by default. So sudo is not needed for the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sylvestre Plesae suggest what we could do about the sudo issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coreutils/tests/by-util/test_cp.rs
Lines 2443 to 2446 in b5561e7
| // Test must be run as root (or with `sudo -E`) | |
| if scene.cmd("whoami").run().stdout_str() != "root\n" { | |
| return; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cakebaker #8605 (comment) Is this standard way for tests with sudo at here?
02cca37 to
7723a4f
Compare
|
GNU testsuite comparison: |
91c048d to
7e163fc
Compare
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8605 will improve performances by 2.22%Comparing Summary
Benchmarks breakdown
Footnotes
|
0e0b27e to
b883bf1
Compare
|
GNU testsuite comparison: |
b883bf1 to
a4ed94c
Compare
|
GNU testsuite comparison: |
a4ed94c to
8b1b869
Compare
|
GNU testsuite comparison: |
|
Still failing? Would you rerun test? |
8b1b869 to
04dc5c7
Compare
04dc5c7 to
9340bf4
Compare
|
GNU testsuite comparison: |
Closes #8586.