Skip to content

Conversation

@yuankunzhang
Copy link
Contributor

Closes #8586.

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 2 times, most recently from 55ba4db to ef80a6d Compare September 10, 2025 15:49
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from ef80a6d to 20d8165 Compare September 12, 2025 13:51
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 20d8165 to 02cca37 Compare September 13, 2025 13:12
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

}

#[cfg(all(unix, not(target_os = "android")))]
#[ignore = "requires sudo"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the ignore
we do run some tests as root in the ci

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to make the tests work. Do you mind take a look at the error outputs and provide suggestions? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sudo executable is not available in the test. Even a simple sudo ls would fail:

run: sudo -E --non-interactive ls

thread 'test_mv::test_mv_broken_symlink_to_another_fs' panicked at tests/uutests/src/lib/util.rs:1976:37:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

https://github.com/uutils/coreutils/actions/runs/18166245128/job/51709489403?pr=8605#step:14:4625

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux have /tmp by default. So sudo is not needed for the test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre Plesae suggest what we could do about the sudo issue here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Test must be run as root (or with `sudo -E`)
if scene.cmd("whoami").run().stdout_str() != "root\n" {
return;
}

Copy link
Contributor

@oech3 oech3 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cakebaker #8605 (comment) Is this standard way for tests with sudo at here?

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 02cca37 to 7723a4f Compare September 27, 2025 13:30
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 3 times, most recently from 91c048d to 7e163fc Compare September 27, 2025 14:23
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #8605 will improve performances by 2.22%

Comparing yuankunzhang:mv-folder-containing-symlinks-across-fs (9340bf4) with main (4ee588e)

Summary

⚡ 1 improvement
✅ 125 untouched
⏩ 6 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
cp_large_file[16] 344.1 µs 336.7 µs +2.22%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 2 times, most recently from 0e0b27e to b883bf1 Compare September 27, 2025 15:28
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from b883bf1 to a4ed94c Compare October 1, 2025 14:27
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from a4ed94c to 8b1b869 Compare October 1, 2025 14:53
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Contributor

oech3 commented Nov 9, 2025

Still failing? Would you rerun test?
[Edit] Thankyou.

@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 8b1b869 to 04dc5c7 Compare November 21, 2025 10:06
@yuankunzhang yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 04dc5c7 to 9340bf4 Compare November 21, 2025 10:08
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mv: 0.2.0 mv cannot move directory with symlink to tmpfs mountpoint

3 participants