Remove lossy OS string conversions #9337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes up a lot for quoted strings in messages: OS strings can be quoted directly and this prevents information loss. This commit removes ~60% of the calls to these methods (modulo tests). Some of the remaining calls are benign, for example because they convert solely to check for the presence of ASCII characters. Others are nontrivial to improve.
CodSpeed Performance ReportMerging #9337 will degrade performances by 4.85%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
GNU testsuite comparison: |
Contributor
|
Seems that some are not. Unnecessary |
Part of the error message was left out due to a misreading of tests/chmod/no-x's output. It filters out this part for the sake of normalization between different tools.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
Should be good now. The problem was error message formatting, not the sanitization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of the unnecessary lossy OS string conversions (
Path::display(),.to_string_lossy()). There are many more left but this gets the low-hanging fruit.Most of these conversions happened for formatted messages. This is unnecessary because
.quote()/.maybe_quote()can already handle OS strings. Sometimes those methods weren't used yet even though they should be so I added them (and removed manual quotation from the translations).I also applied
OsWrite/println_verbatimin a few places where we need to write unformatted OS strings to stdout. See c804e51.