base32, base64, baseenc:Simplifying the base encoding uu_app and adding basic buffer tests #9409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I see the Github actions tests failed on an infrastructure issue after adding that spellcheck flag, I'm guessing its a bit flaky |
ChrisDryden
changed the title
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on systematically going through the CodeCoverage to see what areas have gaps to add testing for. I saw that for the base encoding bins the uu_app did not have coverage and it was because it was following a format where the code to create the command was being duplicated. I did a bit of a refactor so that the code to create the uu_app can follow a similar format of all of the other bins. This also has the side effect of increasing the code coverage.
I also noticed that the code that tests the buffering when encoding did not have a test to cover that use case, so I added a very basic one to go through that code path and validate that the output is still being converted correctly.