timeout: Improve error handling with explicit expect messages #9435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace generic .unwrap() calls with .expect() and more explicit error handling patterns. This improves robustness while making failure modes clear and debuggable.
9 tasks
naoNao89
force-pushed
the
timeout-error-handling
branch
from
63898ee to
d6b7467
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace generic
.unwrap()calls with.expect()containing descriptive messages that document critical assumptions about signal availability and argument validation.SIGTERM:.expect("TERM signal should always be valid")SIGKILL:.expect("KILL signal should always be valid")SIGCONT:.expect("CONT signal should always be valid")These are POSIX.1 standard signals guaranteed on all Unix systems. See GNU manual - Signal specifications.