sync: Reset O_NONBLOCK flag after file validation to match GNU behavior #9437
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
naoNao89
force-pushed
the
sync-remove-unwrap
branch
2 times, most recently
from
9ccd94f to
9ac5413
Compare
naoNao89
force-pushed
the
sync-remove-unwrap
branch
from
9ac5413 to
75a3e0c
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper flag reset logic to the
syncutility to align with GNU coreutils implementation.Changes
O_NONBLOCKflag before callingsyncfs()andfdatasync()fcntl,FcntlArg,OFlag, andAsRawFdThe implementation ensures proper handling of non-blocking file descriptors before performing synchronization operations.
https://www.gnu.org/software/coreutils/manual/html_node/sync-invocation.html