Skip to content

fix: support make serve on mac os #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: support make serve on mac os #485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df172df
fix: Support make serve on mac os
butler54 Oct 6, 2024
9bf702d
fix: correct port passthrough on a mac
butler54 Oct 7, 2024
182a1ec
fix: cleanup
butler54 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
HOMEPAGE_CONTAINER ?= quay.io/hybridcloudpatterns/homepage-container:latest
UNAME=$(shell uname -s)

PODMAN_OPTS ?= -it --security-opt label=disable --pull=newer --net=host

# Can't use host networks on MacOS as it's a VM anyway.
# Also because of the proxy 127.0.0.1 doesn't work as a bind address.
ifeq ($(UNAME), Darwin)
PODMAN_OPTS ?= -it --security-opt label=disable --pull=newer -p 4000:4000
HUGO_SERVER_OPTS = --bind 0.0.0.0
else
PODMAN_OPTS ?= -it --security-opt label=disable --pull=newer --net=host
endif
# Do not use selinux labeling when we are using nfs
FSTYPE=$(shell df -Th . | grep -v Type | awk '{ print $$2 }')

ifeq ($(FSTYPE), nfs)
ATTRS = "rw"
else ifeq ($(FSTYPE), nfs4)
ATTRS = "rw"
else ifeq ($(UNAME), Darwin)
ATTRS = "rw"
else
ATTRS = "rw,z"
endif
Expand All @@ -30,7 +40,7 @@ build: ## Build the website locally in the public/ folder
.PHONY: serve
serve: ## Build the website locally from a container and serve it
@echo "Serving via container. Browse to http://localhost:4000"
podman run $(PODMAN_OPTS) -v $(PWD):/site:$(ATTRS) --entrypoint hugo $(HOMEPAGE_CONTAINER) server -p 4000
podman run $(PODMAN_OPTS) -v $(PWD):/site:$(ATTRS) --entrypoint hugo $(HOMEPAGE_CONTAINER) server -p 4000 $(HUGO_SERVER_OPTS)

.PHONY: htmltest
htmltest: build ## Runs htmltest against the site to find broken links
Expand Down