update pattern deletion logic #469
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dminnear-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this commit includes two key changes: 1. A sync with prune is triggered to remove all applications part of the pattern BEFORE the subscriptions and other resources are deleted to prevent applications from becoming undeleteable if CRs, webhooks, etc disappear. 2. Subscription for openshift-gitops is no longer owned by pattern instances. Previously, deleting a pattern would delete this subscription and a new subscription would not be able to be created on the reinstall of a pattern since the CSV still existed. The subscription is necessary since it sets the env var ARGOCD_CLUSTER_CONFIG_NAMESPACES to '*'. Without the subscription the ArgoCD instance created by the new pattern would be created in namespaced mode and many charts like vault will not install since they try to create clusterwide resources like clusterrolebindings
dminnear-rh
force-pushed
the
pattern-delete
branch
from
83788a6 to
9aab6c0
Compare
Contributor
|
/recheck |
Contributor
|
/lgtm |
Contributor
|
/recheck |
1 similar comment
Contributor
|
/recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit includes two key changes: