Skip to content

Conversation

@gwynne
Copy link
Member

@gwynne gwynne commented Aug 25, 2025

New interpolations:

"SELECT \(col: \FooModel.$bar) FROM \(FooModel.sqlTable)" as SQLQueryString
"""
INSERT INTO \(FooModel.sqlTable)
    (\(ident: \FooModel.$bar), \(ident: FooModel.$baz))
VALUES
    ()
""" as SQLQueryString

@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy August 25, 2025 16:26
@gwynne gwynne force-pushed the query-string-keypath-interpolation branch from 3870aea to 5b3a9bb Compare August 25, 2025 16:53
@@ -0,0 +1,19 @@
#if FluentSQLKitExtras
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't remember you're already using package traits

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this package was my very first use of traits. Still my only one so far, in fact.

@gwynne gwynne merged commit 884d856 into main Aug 25, 2025
5 checks passed
@gwynne gwynne deleted the query-string-keypath-interpolation branch August 25, 2025 17:50
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (b50120e) to head (5b3a9bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   91.25%   91.29%   +0.03%     
==========================================
  Files          62       63       +1     
  Lines         949      953       +4     
==========================================
+ Hits          866      870       +4     
  Misses         83       83              
Files with missing lines Coverage Δ
...rces/FluentKitExtras/OptionalPointerProperty.swift 65.90% <ø> (ø)
...es/FluentKitExtras/OptionalReferenceProperty.swift 86.00% <ø> (ø)
Sources/FluentKitExtras/PointerProperty.swift 81.33% <ø> (ø)
Sources/FluentKitExtras/ReferencesProperty.swift 86.91% <ø> (ø)
...xtras/Builders/SQLJoinBuilder+FluentKeypaths.swift 95.23% <100.00%> (ø)
...as/Expressions/SQLQueryString+FluentKeypaths.swift 100.00% <100.00%> (ø)
...as/SQLKitExtras/BuiltinExpressions/SQLColumn.swift 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants