feat: support import.meta.env in worker URL template literals #21016
+269
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Allows template literals containing only import.meta.env.* expressions
in Web Worker URL definitions, transforming them to string concatenation.
Before (blocked with error):
```javascript
const worker = new Worker(
new URL(\`./path/\${import.meta.env.MY_VAR}/worker.ts\`, import.meta.url),
{ type: 'module' }
)
```
After (now supported):
The template literal is automatically transformed to:
```javascript
new URL('./path/' + import.meta.env.MY_VAR + '/worker.ts', import.meta.url)
```
Implementation:
- Added transformSafeTemplateLiteral() to detect and transform safe templates
- Only allows import.meta.env.* expressions (no other dynamic variables)
- Transforms safe templates to string concatenation before Rollup processing
- Provides helpful error messages for truly dynamic expressions
- Added test files demonstrating the feature
Technical details:
- Two-pass transform: first transforms safe templates, then processes workers
- Uses AST parsing to validate only safe expressions are present
- Preserves source maps through MagicString transformations
- No new dependencies required
abbasyed
force-pushed
the
feat/worker-url-template-literals
branch
from
b2c8929 to
54a15b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements support for template literals containing
import.meta.env.*expressions in Web Worker URL definitions.Fixes #20900
Problem
Currently, users must use string concatenation for dynamic paths with environment variables in worker URLs:
This is inconsistent with template literal usage elsewhere in Vite and less ergonomic.
Solution
Template literals with
import.meta.env.*expressions are now supported and automatically transformed:Changes
import.meta.env.*expressions allowed)playground/workerSafety
import.meta.env.*expressions in template literalsTesting
playground/workercovering:Breaking Changes
None. This is purely additive functionality.