Skip to content

Conversation

@sbaker617
Copy link

Description

This adds an optional --init_tablet_type_lookup startup flag for vttablet to implement functionality described in this issue.

When present, --init_tablet_type_lookup will result in searching the topology for the current tablet being started. If found, will use the previous tablet type instead of the one passed with --init_tablet_type.

Related Issue(s)

Feature Request: Add ability to restore TabletType on restart based on topology.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 20, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 20, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Oct 20, 2025
@sbaker617 sbaker617 force-pushed the topo-lookup-tablet-type branch from 79a26cd to 4cfab07 Compare October 21, 2025 00:33
Copy link
Contributor

@ejortegau ejortegau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

log.Infof("Found existing tablet record with --init-tablet-type-lookup enabled, using tablet type %v from topology instead of init-tablet-type %v",
existingTablet.Type, tablet.Type)
tablet.Type = existingTablet.Type
// If it was a PRIMARY, preserve the start time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to preserve tablet type PRIMARY? Imagine this:

  • vttablet is running as Primary.
  • vttablet crashes.
  • vtorc fails-over.
  • vttablet gets restarted by systemd.
  • vttablet restores its tablet type to Primary, but there is already a primary set by vtorc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had initially thought the checkPrimaryShip() would handle any conflicts, but seems like it wouldn't revert the tablet back to REPLICA.

added special handling for type detected previously as PRIMARY to be set to REPLICA, allowing checkPrimaryShip() to set back to PRIMARY if appropriate.
f2eb9b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants