-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Implement "Tablet Targeting" RFC #18809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickvanw
wants to merge
5
commits into
main
Choose a base branch
from
nickvanw/direct-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Van Wiggeren <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18809 +/- ##
=======================================
Coverage 69.68% 69.69%
=======================================
Files 1605 1606 +1
Lines 214461 214521 +60
=======================================
+ Hits 149456 149518 +62
+ Misses 65005 65003 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ecfaf3 to
883637f
Compare
Signed-off-by: Nick Van Wiggeren <[email protected]>
883637f to
8ab64dc
Compare
Signed-off-by: Nick Van Wiggeren <[email protected]>
f77286f to
1eb17dd
Compare
1eb17dd to
29e658c
Compare
Signed-off-by: Nick Van Wiggeren <[email protected]>
3ef8159 to
84f29f0
Compare
Signed-off-by: Nick Van Wiggeren <[email protected]>
84f29f0 to
6c49907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for a user to target a specific tablet by alias when doing
USE, instead of only being able to pick a type for a shard. This means that a user can get "stable" routing, which is extremely useful when they don't have access to the underlying MySQL instance and need to do things like debug.Related Issue(s)
#18808
Checklist
AI Disclosure
This PR was written hand-in-hand with Claude Code, which absolutely got the initial few approaches extremely incorrect and required a lot of human help. Robot isn't going to take my job any time soon.