Change SQLStatementCountMismatchException to extend AssertionError
#807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@vladmihalcea Did you have a chance to look at this PR? |
Owner
|
@jpJuni0r No, I haven't had the time to check it. I'm very busy at the moment, so I'll check the existing PRs in October or November. |
Author
|
Alright, thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
SQLStatementCountMismatchExceptionto extendAssertionErrorinstead ofRuntimeExceptionfor better integration with test frameworks. This allows test runners to properly identify assertion failures when SQL statement count validation fails.The change is backward compatible since
AssertionErroris also unchecked and will be caught by existingRuntimeExceptionhandlers.