Skip to content

[Feat] Allow declaring modelSpec resources directly #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2025
+4 −0
Merged

[Feat] Allow declaring modelSpec resources directly #729

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4179c9
Add resources alternative to serving engine
danhubern Oct 9, 2025
2b7d7fe
Merge branch 'main' into resources
zerofishnoodles Oct 13, 2025
10db091
Merge branch 'main' into resources
zerofishnoodles Oct 14, 2025
1e3dc0e
Merge branch 'main' into resources
zerofishnoodles Oct 27, 2025
1f9de11
Merge branch 'main' into resources
zerofishnoodles Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/templates/deployment-vllm-multi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,11 @@ spec:
- name: ucx-port
containerPort: 9999
{{- include "chart.probes" . | indent 10 }}
{{- if $modelSpec.resources }}
resources: {{ toYaml $modelSpec.resources | nindent 12 }}
{{- else }}
resources: {{- include "chart.resources" $modelSpec | nindent 12 }}
{{- end }}
Comment on lines +374 to +378
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To make the template more concise and avoid repeating the resources: key, you can use the ternary function to conditionally define the resource content in a variable. This improves readability and maintainability by reducing code duplication.

          {{- $resourceContent := ternary (toYaml $modelSpec.resources) (include "chart.resources" $modelSpec) $modelSpec.resources }}
          resources: {{- $resourceContent | nindent 12 }}

Copy link
Contributor Author

@danhubern danhubern Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion the proposed change by gemini does not increase readability. However, I will happily apply it if that is the preferred way to go. @YuhanLiu11 or @zerofishnoodles what do you think?

{{- if or (hasKey $modelSpec "pvcStorage") (and $modelSpec.vllmConfig (hasKey $modelSpec.vllmConfig "tensorParallelSize")) (hasKey $modelSpec "chatTemplate") (hasKey $modelSpec "extraVolumeMounts") }}
volumeMounts:
{{- end }}
Expand Down