[Structured Output] Replace apply_grammar_bitmask() method with that in vllm to avoid maintenance
#2524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the code to use the apply_grammar_bitmask function from the upstream vLLM library, removing the local implementation. This is a positive change that reduces code duplication and improves maintainability. The implementation correctly handles the necessary tensor manipulations, such as moving logits to the CPU and handling dtype conversions, which were previously part of the removed method. The changes appear correct and beneficial.
20 tasks
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
shen-shanshan
force-pushed
the
so
branch
2 times, most recently
from
adcefcb to
356dc3b
Compare
…ntenance Signed-off-by: shen-shanshan <[email protected]>
shen-shanshan
added
ready
Collaborator
Author
|
CC @wangxiyuan |
wangxiyuan
approved these changes
Oct 23, 2025
shaopeng-666
pushed a commit
to shaopeng-666/vllm-ascend
that referenced
this pull request
Oct 23, 2025
…t in vllm to avoid maintenance (vllm-project#2524) ### What this PR does / why we need it? Replace `apply_grammar_bitmask()` method with that in vllm to avoid maintenance. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: shaopeng666 <[email protected]>
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…t in vllm to avoid maintenance (vllm-project#2524) ### What this PR does / why we need it? Replace `apply_grammar_bitmask()` method with that in vllm to avoid maintenance. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: luolun <[email protected]>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…t in vllm to avoid maintenance (vllm-project#2524) ### What this PR does / why we need it? Replace `apply_grammar_bitmask()` method with that in vllm to avoid maintenance. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: hwhaokun <[email protected]>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
…t in vllm to avoid maintenance (vllm-project#2524) ### What this PR does / why we need it? Replace `apply_grammar_bitmask()` method with that in vllm to avoid maintenance. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: nsdie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Replace
apply_grammar_bitmask()method with that in vllm to avoid maintenance.