[main] remove dbo code #3712
Merged
[main] remove dbo code #3712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes code related to dbo (dual-batch overlap) in the vLLM project, specifically targeting the ascend platform. The changes involve removing a sample file, environment variable configurations, and related metadata and logic from the attention modules. The review focuses on ensuring the complete removal of dbo-related code and maintaining the project's overall correctness and efficiency.
weijinqian0
approved these changes
Oct 24, 2025
wangxiyuan
approved these changes
Oct 24, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zzzzwwjj
force-pushed
the
rm_dbo_code
branch
2 times, most recently
from
31a428d to
22e20de
Compare
zzzzwwjj
force-pushed
the
rm_dbo_code
branch
3 times, most recently
from
1c36d72 to
42f50f1
Compare
Signed-off-by: zzzzwwjj <[email protected]>
weijinqian0
added
ready
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? Remove codes of dbo. Currently, vLLM has supported dbo with pr: vllm-project/vllm#23693. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a Signed-off-by: zzzzwwjj <[email protected]> Signed-off-by: luolun <[email protected]>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? Remove codes of dbo. Currently, vLLM has supported dbo with pr: vllm-project/vllm#23693. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a Signed-off-by: zzzzwwjj <[email protected]> Signed-off-by: hwhaokun <[email protected]>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
### What this PR does / why we need it? Remove codes of dbo. Currently, vLLM has supported dbo with pr: vllm-project/vllm#23693. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a Signed-off-by: zzzzwwjj <[email protected]> Signed-off-by: nsdie <[email protected]>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 10, 2025
### What this PR does / why we need it? Remove codes of dbo. Currently, vLLM has supported dbo with pr: vllm-project/vllm#23693. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a Signed-off-by: zzzzwwjj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove codes of dbo.
Currently, vLLM has supported dbo with pr: vllm-project/vllm#23693.
Does this PR introduce any user-facing change?
How was this patch tested?