Skip to content

Conversation

@leo-pony
Copy link
Collaborator

@leo-pony leo-pony commented Oct 27, 2025

What this PR does / why we need it?

Fix 310P issues in main.

Test on 310p NPU host, models as following:
Qwen/Qwen3-0.6B
Qwen/Qwen2.5-7B-Instruct
Qwen2.5-VL-3B-Instruct
Test cases are passed.
82847324-7cb2-44fd-b7f7-fa508790fa7c

Know Issue:
For pangu-pro-moe-model model, has error:
ValueError: Unsupported soc_version: AscendSocVersion.UNDEFINED
Detail can see in PR:#2676

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces fixes for the 310P platform. The changes include correcting the model used in a vision-language test, adding a dedicated KV cache initialization path for 310P, and skipping ATB warmup on this platform.

My review identifies a couple of issues in the new _initialize_kv_cache_tensors_310p method. There's a critical bug where the KV cache tensors are created with a hardcoded torch.float16 dtype, which should be corrected to use the dtype from the kv_cache_spec. Additionally, there's a misleading error message when KV cache transfer is used, which could make debugging difficult. I've provided suggestions to fix both of these issues.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wxh571001500
Copy link

@leo-pony Hello, when do you plan to merge this code? My current feature development depends on this modification.

@fengle-great
Copy link

What this PR does / why we need it?

Fix 310P issues in main.

Test on 310p NPU host, models as following: Qwen/Qwen3-0.6B Qwen/Qwen2.5-7B-Instruct Qwen2.5-VL-3B-Instruct Test cases are passed. 82847324-7cb2-44fd-b7f7-fa508790fa7c

Know Issue: For pangu-pro-moe-model model, has error: ValueError: Unsupported soc_version: AscendSocVersion.UNDEFINED Detail can see in PR:#2676

Does this PR introduce any user-facing change?

How was this patch tested?

这部分修改好像只能启动qwen3-vl,启动后可以进行文本推理,但是一旦执行图像推理的时候就挂掉了,报错详情如下:

[rank1]:[E1211 14:16:37.931188062 compiler_depend.ts:444] SelfAttentionOperation setup failed!
Exception raised from OperationSetup at build/third_party/op-plugin/op_plugin/CMakeFiles/op_plugin_atb.dir/compiler_depend.ts:203 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits, std::allocator >) + 0xd4 (0xffff80ae3ea4 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) + 0xe4 (0xffff80a83e44 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch/lib/libc10.so)
frame #2: atb::OperationSetup(atb::VariantPack, atb::Operation*, atb::Context*) + 0x254 (0xffff53a1c0e8 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libop_plugin_atb.so)
frame #3: + 0x9ebec (0xffff53a1ebec in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libop_plugin_atb.so)
frame #4: + 0x26e6c10 (0xffff73166c10 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libtorch_npu.so)
frame #5: + 0x961a94 (0xffff713e1a94 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libtorch_npu.so)
frame #6: + 0x9644c0 (0xffff713e44c0 in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libtorch_npu.so)
frame #7: + 0x96072c (0xffff713e072c in /usr/local/python3.11.13/lib/python3.11/site-packages/torch_npu/lib/libtorch_npu.so)
frame #8: + 0xd29cc (0xffff808f29cc in /lib/aarch64-linux-gnu/libstdc++.so.6)
frame #9: + 0x80398 (0xffff8cbc0398 in /lib/aarch64-linux-gnu/libc.so.6)
frame #10: + 0xe9e9c (0xffff8cc29e9c in /lib/aarch64-linux-gnu/libc.so.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants