[Doc][Example][Bugfix] Elements in local_device_ids should be casted … #3782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to int type before referred. Signed-off-by: paulyu12 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the gen_ranktable.py example script where device IDs from the --local-device-ids argument were not converted to integers, causing errors in subsequent arithmetic operations. The fix is correct in its intent. My review includes a suggestion to make the implementation more robust by adding error handling for invalid inputs. This will prevent the script from crashing and provide a more user-friendly error message if a non-integer value is provided.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Collaborator
|
Except for Gemini's review, LGTM |
…to int type before referred. Signed-off-by: paulyu12 <[email protected]>
Collaborator
Author
|
I've adjusted according to the Gemini's review. |
wangxiyuan
approved these changes
Oct 27, 2025
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
vllm-project#3782) ### What this PR does / why we need it? It's a tiny bugfix in the `gen_ranktable.py` script. The script is an util to help setup an example case. It is used to prepare a ranktable before disaggregated prefill deployment. Elements in `local_device_ids` list should be casted to `int` type before referred for a MOD math operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@c9461e0 --------- Signed-off-by: paulyu12 <[email protected]> Signed-off-by: luolun <[email protected]>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
vllm-project#3782) ### What this PR does / why we need it? It's a tiny bugfix in the `gen_ranktable.py` script. The script is an util to help setup an example case. It is used to prepare a ranktable before disaggregated prefill deployment. Elements in `local_device_ids` list should be casted to `int` type before referred for a MOD math operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@c9461e0 --------- Signed-off-by: paulyu12 <[email protected]> Signed-off-by: hwhaokun <[email protected]>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
vllm-project#3782) ### What this PR does / why we need it? It's a tiny bugfix in the `gen_ranktable.py` script. The script is an util to help setup an example case. It is used to prepare a ranktable before disaggregated prefill deployment. Elements in `local_device_ids` list should be casted to `int` type before referred for a MOD math operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@c9461e0 --------- Signed-off-by: paulyu12 <[email protected]> Signed-off-by: nsdie <[email protected]>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 10, 2025
vllm-project#3782) ### What this PR does / why we need it? It's a tiny bugfix in the `gen_ranktable.py` script. The script is an util to help setup an example case. It is used to prepare a ranktable before disaggregated prefill deployment. Elements in `local_device_ids` list should be casted to `int` type before referred for a MOD math operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@c9461e0 --------- Signed-off-by: paulyu12 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
It's a tiny bugfix in the
gen_ranktable.pyscript. The script is an util to help setup an example case. It is used to prepare a ranktable before disaggregated prefill deployment.Elements in
local_device_idslist should be casted tointtype before referred for a MOD math operation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.