Skip to content

Conversation

@menogrey
Copy link
Contributor

What this PR does / why we need it?

This is cherry-pick from #3798

Fix kimi-k2 start bug, weight load
ERROR:#3785

Does this PR introduce any user-facing change?

How was this patch tested?

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the packed module mapping for the kimi-k2 model, which is a necessary bugfix for enabling weight loading in quantized scenarios. The change is straightforward and addresses the issue. I have included one suggestion to improve the code formatting for better readability and adherence to standard Python style conventions.

Comment on lines +198 to +199
"experts":
["experts.0.gate_proj", "experts.0.up_proj", "experts.0.down_proj"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For better readability and adherence to Python's style guide, this list should be formatted more conventionally. The current layout, where the list value starts on a new line at the same indentation level as its key, is inconsistent with PEP 8.1

        "experts": [
            "experts.0.gate_proj",
            "experts.0.up_proj",
            "experts.0.down_proj",
        ]

Style Guide References

Footnotes

  1. PEP 8, the style guide for Python code, recommends consistent indentation for continuation lines to improve readability. The value associated with a dictionary key should either be on the same line or indented on the following lines.

Signed-off-by: Levi-JQ <[email protected]>

### What this PR does / why we need it?
Fix kimi-k2 start bug, weight load
ERROR:vllm-project#3785

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.11.0rc3
- vLLM main:
vllm-project/vllm@c9461e0

Signed-off-by: Levi-JQ <[email protected]>
Co-authored-by: Levi-JQ <[email protected]>
Co-authored-by: zhaozx-cn <[email protected]>
Signed-off-by: menogrey <[email protected]>
@wangxiyuan wangxiyuan merged commit a7eb42c into vllm-project:v0.11.0-dev Nov 14, 2025
16 checks passed
Clorist33 pushed a commit to Clorist33/vllm-ascend that referenced this pull request Dec 9, 2025
…llm-project#4190)

### What this PR does / why we need it?
This is cherry-pick from vllm-project#3798 

Fix kimi-k2 start bug, weight load
ERROR:vllm-project#3785

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.11.0rc3
- vLLM main:
vllm-project/vllm@c9461e0

---------

Signed-off-by: Levi-JQ <[email protected]>
Signed-off-by: menogrey <[email protected]>
Co-authored-by: Levi <[email protected]>
Co-authored-by: Levi-JQ <[email protected]>
Co-authored-by: zhaozx-cn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants