improve soc version #4522
Merged
improve soc version #4522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces aliases for SoC versions to simplify configuration. The changes add new short names for different chip versions in setup.py and map them to the full version names required by CMake. My review includes a suggestion to refactor the mapping logic from an if/elif/else chain to a dictionary lookup, which will improve code readability and make it easier to maintain and extend in the future.
wangxiyuan
force-pushed
the
update_soc_verison
branch
from
1563219 to
0506101
Compare
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
force-pushed
the
update_soc_verison
branch
from
0506101 to
ce40df1
Compare
Collaborator
Author
|
MengqingCao
approved these changes
Nov 29, 2025
ChenCangtao
pushed a commit
to ChenCangtao/vllm-ascend
that referenced
this pull request
Dec 3, 2025
Make SOC_VERSION be readable for users. Now users can set simply "910b"、“910c”、“310p” - vLLM version: v0.11.2 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.2 Signed-off-by: wangxiyuan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Dec 4, 2025
Make SOC_VERSION be readable for users. Now users can set simply "910b"、“910c”、“310p” - vLLM version: v0.11.2 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.2 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Dec 4, 2025
Make SOC_VERSION be readable for users. Now users can set simply "910b"、“910c”、“310p” - vLLM version: v0.11.2 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.2 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Meihan-chen
pushed a commit
to Meihan-chen/vllm-ascend
that referenced
this pull request
Dec 5, 2025
Make SOC_VERSION be readable for users. Now users can set simply "910b"、“910c”、“310p” - vLLM version: v0.11.2 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.2 Signed-off-by: wangxiyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make SOC_VERSION be readable for users. Now users can set simply "910b"、“910c”、“310p”