Skip to content

Conversation

@shen-shanshan
Copy link
Collaborator

@shen-shanshan shen-shanshan commented Nov 29, 2025

What this PR does / why we need it?

Following #4349, remove Qwen3-VL modeling files.

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Qwen3-VL model integration by removing the dedicated model files and using a patch-based approach instead. This is a good simplification that aligns with how other models are handled in this repository. The changes are generally correct and improve the code structure. I have one suggestion in the new patch file to replace numpy-based tensor operations with more efficient and idiomatic torch operations, which will improve performance and maintainability.

@shen-shanshan shen-shanshan added ready read for review ready-for-test start test by label for PR labels Nov 29, 2025
shen-shanshan and others added 4 commits November 29, 2025 23:06
Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: Shanshan Shen <[email protected]>
Signed-off-by: Shanshan Shen <[email protected]>
Signed-off-by: Shanshan Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants