-
Notifications
You must be signed in to change notification settings - Fork 629
add _cann_ops_custom gitignore #4605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add the _cann_ops_custom directory, which contains generated files, to .gitignore. While this is the correct intention, the current implementation ignores the entire directory, which conflicts with the presence of a .gitkeep file designed to keep the directory in the repository. My review provides a suggestion to correctly ignore the directory's contents while preserving the .gitkeep file, ensuring repository integrity for new clones.
.gitignore
Outdated
| /benchmarks/results/ | ||
|
|
||
| # _cann_ops_custom generated by build_aclnn.sh | ||
| /vllm_ascend/_cann_ops_custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the entire /vllm_ascend/_cann_ops_custom directory conflicts with the presence of the .gitkeep file within it. The purpose of .gitkeep is to ensure the directory is tracked in the repository, even when empty. If you ignore the parent directory, you cannot track any files inside it, including .gitkeep.
To correctly ignore the generated contents while keeping the directory and its .gitkeep file tracked, you should ignore all contents of the directory and then explicitly un-ignore the .gitkeep file.
/vllm_ascend/_cann_ops_custom/*
!/vllm_ascend/_cann_ops_custom/.gitkeep
Signed-off-by: zzzzwwjj <[email protected]>
808d435 to
15202e3
Compare
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
### What this PR does / why we need it? add _cann_ops_custom dir to .gitignore - vLLM version: v0.11.2 Signed-off-by: zzzzwwjj <[email protected]>
### What this PR does / why we need it? add _cann_ops_custom dir to .gitignore - vLLM version: v0.11.2 Signed-off-by: zzzzwwjj <[email protected]> Signed-off-by: Che Ruan <[email protected]>
### What this PR does / why we need it? add _cann_ops_custom dir to .gitignore - vLLM version: v0.11.2 Signed-off-by: zzzzwwjj <[email protected]> Signed-off-by: Che Ruan <[email protected]>
### What this PR does / why we need it? add _cann_ops_custom dir to .gitignore - vLLM version: v0.11.2 Signed-off-by: zzzzwwjj <[email protected]>
What this PR does / why we need it?
add _cann_ops_custom dir to .gitignore
Does this PR introduce any user-facing change?
How was this patch tested?