Skip to content

Conversation

@zzzzwwjj
Copy link
Collaborator

@zzzzwwjj zzzzwwjj commented Dec 1, 2025

What this PR does / why we need it?

add _cann_ops_custom dir to .gitignore

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add the _cann_ops_custom directory, which contains generated files, to .gitignore. While this is the correct intention, the current implementation ignores the entire directory, which conflicts with the presence of a .gitkeep file designed to keep the directory in the repository. My review provides a suggestion to correctly ignore the directory's contents while preserving the .gitkeep file, ensuring repository integrity for new clones.

.gitignore Outdated
/benchmarks/results/

# _cann_ops_custom generated by build_aclnn.sh
/vllm_ascend/_cann_ops_custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Ignoring the entire /vllm_ascend/_cann_ops_custom directory conflicts with the presence of the .gitkeep file within it. The purpose of .gitkeep is to ensure the directory is tracked in the repository, even when empty. If you ignore the parent directory, you cannot track any files inside it, including .gitkeep.

To correctly ignore the generated contents while keeping the directory and its .gitkeep file tracked, you should ignore all contents of the directory and then explicitly un-ignore the .gitkeep file.

/vllm_ascend/_cann_ops_custom/*
!/vllm_ascend/_cann_ops_custom/.gitkeep

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan merged commit 3023e15 into vllm-project:main Dec 1, 2025
17 checks passed
ChenCangtao pushed a commit to ChenCangtao/vllm-ascend that referenced this pull request Dec 3, 2025
### What this PR does / why we need it?
add _cann_ops_custom dir to .gitignore

- vLLM version: v0.11.2

Signed-off-by: zzzzwwjj <[email protected]>
Mercykid-bash pushed a commit to Mercykid-bash/vllm-ascend that referenced this pull request Dec 4, 2025
### What this PR does / why we need it?
add _cann_ops_custom dir to .gitignore

- vLLM version: v0.11.2

Signed-off-by: zzzzwwjj <[email protected]>
Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash pushed a commit to Mercykid-bash/vllm-ascend that referenced this pull request Dec 4, 2025
### What this PR does / why we need it?
add _cann_ops_custom dir to .gitignore

- vLLM version: v0.11.2

Signed-off-by: zzzzwwjj <[email protected]>
Signed-off-by: Che Ruan <[email protected]>
Meihan-chen pushed a commit to Meihan-chen/vllm-ascend that referenced this pull request Dec 5, 2025
### What this PR does / why we need it?
add _cann_ops_custom dir to .gitignore

- vLLM version: v0.11.2

Signed-off-by: zzzzwwjj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants