-
Notifications
You must be signed in to change notification settings - Fork 624
Drop ascend scheduler #4623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drop ascend scheduler #4623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the custom ascend_scheduler and its related configurations, making the system fall back to the default vLLM scheduler. The changes primarily consist of deleting code that is no longer necessary. My review identified a critical syntax error in vllm_ascend/platform.py that will prevent the code from running. I have also pointed out a potential logic regression in the same file concerning the configuration of the cache block size, which might lead to incorrect behavior under the default scheduler.
1990cae to
3108873
Compare
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
3108873 to
b35d419
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
b35d419 to
0f69c4b
Compare
0f69c4b to
71ac838
Compare
Signed-off-by: wangxiyuan <[email protected]>
71ac838 to
44b32a6
Compare
It's safe to drop ascend scheduler now. The related test and doc has been removed already