Skip to content

Conversation

@1092626063
Copy link
Contributor

@1092626063 1092626063 commented Dec 2, 2025

What this PR does / why we need it?

fix deepseekv3.1 doc

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for DeepSeek-V3.1, specifically for the 'Prefill-Decode Disaggregation' section. The change removes the 'Llmdatadist' option, focusing solely on 'Mooncake' for deployment, which seems appropriate given the context of the model. I've provided one comment to correct a grammatical error in the updated sentence to improve the documentation's clarity and professionalism.

### Prefill-Decode Disaggregation

There are two ways to deploy `Prefill-Decode Disaggregation`: [Llmdatadist](./multi_node_pd_disaggregation_llmdatadist.md) and [Mooncake](./multi_node_pd_disaggregation_mooncake.md). We recommend use Mooncake for deploy.
We recommend to use Mooncake for deploy: [Mooncake](./multi_node_pd_disaggregation_mooncake.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To improve grammatical correctness and clarity, I suggest rephrasing this sentence. The verb 'recommend' is typically followed by a gerund (e.g., 'using') rather than an infinitive ('to use'). Additionally, the noun form of the verb 'deploy' is 'deployment'.

Suggested change
We recommend to use Mooncake for deploy: [Mooncake](./multi_node_pd_disaggregation_mooncake.md).
We recommend using Mooncake for deployment: [Mooncake](./multi_node_pd_disaggregation_mooncake.md).

Signed-off-by: AiChiMomo <[email protected]>
@MengqingCao MengqingCao merged commit b84c9af into vllm-project:main Dec 2, 2025
15 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants