Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Dec 2, 2025

What this PR does / why we need it?

Fix ngram lacking of input arg dummy_compute_logits error

How was this patch tested?

CI passed with existing test.
image

Signed-off-by: MengqingCao <[email protected]>
@MengqingCao MengqingCao changed the title [CI] Fix ngram lacking of input arg dummy_compute_logits error [v0.11.0-dev][CI] Fix ngram lacking of input arg dummy_compute_logits error Dec 2, 2025
@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Dec 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a lacking of input arg error by introducing the dummy_compute_logits parameter with a default no-op lambda function to the dummy_run methods in interface.py and ngram_proposer.py. This change ensures compatibility and resolves the reported error without introducing new issues. The addition of the -> None return type hint in interface.py also improves code clarity.

Signed-off-by: MengqingCao <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@MengqingCao MengqingCao merged commit b6d63bb into vllm-project:v0.11.0-dev Dec 3, 2025
16 checks passed
@MengqingCao MengqingCao deleted the fixci-dev branch December 3, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant