Skip to content

Conversation

@wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Dec 3, 2025

This reverts commit 4588cda.

This change broke test_models_distributed_QwQ e2e test. Let's revert it first.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Collaborator

@MengqingCao MengqingCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after all CI passed

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Dec 3, 2025
@wangxiyuan
Copy link
Collaborator Author

let's focus on #4675 first.

@wangxiyuan wangxiyuan closed this Dec 3, 2025
@wangxiyuan wangxiyuan deleted the revert_1203 branch December 4, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants