Remove ascend schuduler ut #4684
Merged
+6
−948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes unit test files for Ascend scheduler components. While the AscendScheduler is deprecated, this PR also removes active tests for AscendSchedulerConfig and SchedulerDynamicBatch. Deleting tests for existing code is a critical issue as it removes test coverage and increases the risk of future regressions. The tests for AscendSchedulerConfig and SchedulerDynamicBatch should be restored, or the classes themselves should be removed if they are also obsolete.
wangxiyuan
force-pushed
the
drop_1
branch
4 times, most recently
from
0ae798e to
766a6de
Compare
Signed-off-by: wangxiyuan <[email protected]>
weijinqian0
approved these changes
Dec 4, 2025
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Dec 4, 2025
### What this PR does / why we need it? 1. Remove ascend schuduler ut 2. Remove models ut 3. move mla to ops 4. skip the failed ut - vLLM version: v0.12.0 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Mercykid-bash
pushed a commit
to Mercykid-bash/vllm-ascend
that referenced
this pull request
Dec 4, 2025
### What this PR does / why we need it? 1. Remove ascend schuduler ut 2. Remove models ut 3. move mla to ops 4. skip the failed ut - vLLM version: v0.12.0 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?