Skip to content

Conversation

@wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Dec 4, 2025

Correct vLLM version in doc

Signed-off-by: wangxiyuan <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM version across several documentation files. The changes are a good step towards updating the repository for the new version. However, I've noticed a few inconsistencies where the version number has not been updated, specifically in the 'Getting Started' sections of the README files and the 'Release window' section in the versioning policy. I've added comments on the release checklist file pointing out these missed updates, as they are now explicitly part of the release process. Addressing these will ensure the documentation is consistent for users.

- [ ] Add release note to docs/source/user_guide/release_notes.md
- [ ] Update release version in README.md and README.zh.md
- [ ] Update release version in README.md and README.zh.md (Getting Started and Branch section)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While the 'Branch section' in README.md and README.zh.md has been updated to v0.12.0, the 'Getting Started' section in both files still refers to v0.11.0rc3. To ensure consistency and fulfill this checklist item, please update the 'Getting Started' sections as well.

- [ ] Update release version in README.md and README.zh.md (Getting Started and Branch section)
- [ ] Update version info in docs/source/community/versioning_policy.md
- [ ] Update version info in docs/source/community/versioning_policy.md(Release compatibility matrix, Release window and Branch states section)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The 'Branch states' section in docs/source/community/versioning_policy.md has been updated. However, the 'Release window' section has not been updated to include the new v0.12.0 release. As per this checklist item, please add an entry for the new version to the 'Release window' table to keep the documentation consistent.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan changed the title Update vLLM version in doc [Doc] Update vLLM version in doc Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant