-
Notifications
You must be signed in to change notification settings - Fork 624
[Doc] Update vLLM version in doc #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: wangxiyuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the vLLM version across several documentation files. The changes are a good step towards updating the repository for the new version. However, I've noticed a few inconsistencies where the version number has not been updated, specifically in the 'Getting Started' sections of the README files and the 'Release window' section in the versioning policy. I've added comments on the release checklist file pointing out these missed updates, as they are now explicitly part of the release process. Addressing these will ensure the documentation is consistent for users.
| - [ ] Add release note to docs/source/user_guide/release_notes.md | ||
| - [ ] Update release version in README.md and README.zh.md | ||
| - [ ] Update release version in README.md and README.zh.md (Getting Started and Branch section) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [ ] Update release version in README.md and README.zh.md (Getting Started and Branch section) | ||
| - [ ] Update version info in docs/source/community/versioning_policy.md | ||
| - [ ] Update version info in docs/source/community/versioning_policy.md(Release compatibility matrix, Release window and Branch states section) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'Branch states' section in docs/source/community/versioning_policy.md has been updated. However, the 'Release window' section has not been updated to include the new v0.12.0 release. As per this checklist item, please add an entry for the new version to the 'Release window' table to keep the documentation consistent.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Correct vLLM version in doc