Skip to content

Conversation

@Pr0Wh1teGivee
Copy link
Contributor

@Pr0Wh1teGivee Pr0Wh1teGivee commented Dec 11, 2025

What this PR does / why we need it?

Remove FusedMoEState which is used by torchair.

Does this PR introduce any user-facing change?

No

How was this patch tested?

e2e & ut

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the FusedMoEState enum from vllm_ascend/ascend_forward_context.py. As this enum is no longer used within the codebase, this change is a beneficial code cleanup that improves maintainability by removing dead code. My review of the provided changes did not identify any issues.

@Pr0Wh1teGivee Pr0Wh1teGivee changed the title Remove FusedMoEState [MoE][TorchAir] Remove FusedMoEState Dec 11, 2025
Signed-off-by: weichen <[email protected]>
@weijinqian0 weijinqian0 added ready read for review ready-for-test start test by label for PR labels Dec 11, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan merged commit d54db76 into vllm-project:main Dec 12, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants