-
Notifications
You must be signed in to change notification settings - Fork 665
[Pangu][MoE] Remove PanguProMoEV1 related code #5088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pangu][MoE] Remove PanguProMoEV1 related code #5088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes code related to PanguProMoEV1, which is no longer supported. The changes are straightforward and consist of deleting the TokenDispatcherWithMoge class and removing conditional logic specific to PanguProMoE in AllGatherCommImpl and NPUModelRunner. The modifications are consistent with the goal of cleaning up deprecated code. I've reviewed the changes and they appear correct and complete within the provided context. I did not find any high or critical issues.
7673307 to
3d00808
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
3d00808 to
dd9f00c
Compare
67d72b4 to
6d80904
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
6d80904 to
14ffe4a
Compare
Signed-off-by: weichen <[email protected]>
6b1765d to
b59463d
Compare
What this PR does / why we need it?
PanguProMoEV1 is no longer supported in vllm-ascend, remove related code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
e2e & ut