Skip to content

Conversation

@Pr0Wh1teGivee
Copy link
Contributor

@Pr0Wh1teGivee Pr0Wh1teGivee commented Dec 16, 2025

What this PR does / why we need it?

PanguProMoEV1 is no longer supported in vllm-ascend, remove related code.

Does this PR introduce any user-facing change?

No

How was this patch tested?

e2e & ut

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes code related to PanguProMoEV1, which is no longer supported. The changes are straightforward and consist of deleting the TokenDispatcherWithMoge class and removing conditional logic specific to PanguProMoE in AllGatherCommImpl and NPUModelRunner. The modifications are consistent with the goal of cleaning up deprecated code. I've reviewed the changes and they appear correct and complete within the provided context. I did not find any high or critical issues.

@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the remove_pangu_related branch 2 times, most recently from 7673307 to 3d00808 Compare December 16, 2025 09:25
@Pr0Wh1teGivee Pr0Wh1teGivee changed the title Remove PanguProMoEV1 related code [Pangu][MoE] Remove PanguProMoEV1 related code Dec 16, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the remove_pangu_related branch 2 times, most recently from 67d72b4 to 6d80904 Compare December 16, 2025 11:09
@weijinqian0 weijinqian0 added ready read for review ready-for-test start test by label for PR labels Dec 16, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wangxiyuan wangxiyuan merged commit f0060fc into vllm-project:main Dec 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ops ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants