[ci/testing]: ensure the gpu memory is cleaned when exiting the remote openAI remote server #24258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AI server Signed-off-by: AzizCode92 <[email protected]>
3 tasks
AzizCode92
changed the title
Signed-off-by: AzizCode92 <[email protected]>
AzizCode92
changed the title
AzizCode92
changed the title
tests/utils.py
Outdated
| self.proc.kill() | ||
| # GPU memory cleanup | ||
| try: | ||
| if torch.cuda.is_available(): |
Member
There was a problem hiding this comment.
Let's use current_platform so that the tests can run on other platforms as well
Signed-off-by: AzizCode92 <[email protected]>
Centralizes the GPU memory cleanup logic into a single static method to prevent flaky test failures from OOM errors. Signed-off-by: AzizCode92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
__exit__method of theRemoteOpenAIServeris not sufficient to clean up GPU memory.This creates a race condition between the different tests in CI.
This PR ensures we properly clean the GPU memory when exiting the openAI remote server.
Solves: #24144
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.