Skip to content

Conversation

@ZJY0516
Copy link
Contributor

@ZJY0516 ZJY0516 commented Sep 5, 2025

Purpose

Refactor the fp8 folder to 8bit, then includes fp8 and int8 folders

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@ZJY0516
Copy link
Contributor Author

ZJY0516 commented Sep 5, 2025

cc @yewentao256

@mergify mergify bot added the ci/build label Sep 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the quantization-related files by moving them into a new 8bit directory. While most of the changes are correct path updates, I've found several instances where the #include paths have been updated incorrectly. These new paths seem to assume that csrc is an include directory, which is inconsistent with other files in this pull request that use relative paths. This inconsistency will likely cause the build to fail. I've left specific comments with suggestions to fix these paths.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZJY0516 Thanks! We already have a PR for this #22474, pending for cutlass update from @mgoin

@ZJY0516
Copy link
Contributor Author

ZJY0516 commented Sep 5, 2025

Understood, thanks! I'll check for related PRs next time 😭

@ZJY0516 ZJY0516 closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants