[Bugfix][plugin] fla crash on plugin #27322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There's some problem while supporting fla on plugin.
While importing the
fla/ops/utils, it crashed on here.Since in plugin the
devicemight got their own value (here in vllm-metax ismaca) anddevice_torch_libstill need to be their own. (here in vllm-metax istorch.cuda)So I use is_cuda_alike and set default value to None on
getattrto make some compatibilities for handling the corner cases. The semantics should be consistent with the original code.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.