Skip to content

Update FAQ on interleaving sliding windows support #29796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heheda12345 merged 2 commits into from
Dec 1, 2025
Merged

Update FAQ on interleaving sliding windows support #29796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aade593
Update FAQ on interleaving sliding windows support
finbarrtimbers Dec 1, 2025
7138a99
Merge branch 'main' into patch-1
finbarrtimbers Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/contributing/model/basic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ See [this page](registration.md) for instructions on how to register your new mo

### How to support models with interleaving sliding windows?

For models with interleaving sliding windows (e.g. `google/gemma-2-2b-it` and `mistralai/Ministral-8B-Instruct-2410`), the scheduler will treat the model as a full-attention model, i.e., kv-cache of all tokens will not be dropped. This is to make sure prefix caching works with these models. Sliding window only appears as a parameter to the attention kernel computation.

To support a model with interleaving sliding windows, we need to take care of the following details:

- Make sure the model's `config.json` contains `layer_types`.
Expand Down