Skip to content

Strengthen input validation and tests for 'parse_raw_prompts’. #30652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 7 commits into from
Dec 18, 2025
Merged

Strengthen input validation and tests for 'parse_raw_prompts’. #30652

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4773df8
Added a test for invalid inputs for parse_raw_prompts
mivehk Dec 11, 2025
0ac3b2f
Updated the invalid_input condition for parse_raw_prompt
mivehk Dec 11, 2025
c9a523a
Updated parse_raw_promptinput validation tests - uv pre-commit installed
mivehk Dec 11, 2025
d9dd01d
Added strict validation for nested array inputs in parse_raw_prompts
mivehk Dec 14, 2025
4c8d1fc
Updated parse_raw_prompt control flow to raise ValueError for empty n…
mivehk Dec 15, 2025
5cc0f4a
Updated nested token validation to avoid expensive asymptotic check
mivehk Dec 16, 2025
4651161
Added a test for nested mixed-type list of lists raising TypeError
mivehk Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions vllm/inputs/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,17 @@ def parse_raw_prompts(

# case 4: array of token arrays
if is_list_of(prompt, list):
first = prompt[0]
if not isinstance(first, list):
raise ValueError("prompt expected to be a list of lists")

if len(first) == 0:
raise ValueError("Please provide at least one prompt")

# strict validation: every nested list must be list[int]
if not all(is_list_of(elem, int) for elem in prompt):
raise TypeError("Nested lists must contain only integers")
if len(prompt) == 1 and isinstance(prompt[0], list) and len(prompt[0]) == 0:
raise ValueError("please provide at least one prompt")
for elem in prompt:
if not isinstance(elem, list):
raise TypeError(
"prompt must be a list of lists, but found a non-list element."
)
if not is_list_of(elem, int):
raise TypeError(
"Nested lists of tokens must contain only integers."
)

prompt = cast(list[list[int]], prompt)
return [TokensPrompt(prompt_token_ids=elem) for elem in prompt]
Expand Down