Skip to content

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Dec 15, 2025

Purpose

fix #30107

Test Plan

tests/models/registry.py
tests/models/language/pooling/test_token_classification.py

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automatic conversion for TokenClassification models. This is achieved by adding a mapping for the ForTokenClassification model architecture suffix to treat it as a pooling/classification task, and enhancing the ModelForSequenceClassification adapter to dynamically handle score.bias from model checkpoints. A new test case for a Qwen3-based token classification model is also added to verify the changes. The implementation appears correct and is a good enhancement for robust model conversion. I have not found any issues of high or critical severity.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 15, 2025 05:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 15, 2025
@DarkLight1337 DarkLight1337 merged commit 4429d93 into vllm-project:main Dec 15, 2025
56 checks passed
@noooop noooop deleted the token_classify branch December 15, 2025 08:15
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Dec 15, 2025
joa-stdn pushed a commit to joa-stdn/vllm that referenced this pull request Dec 15, 2025
teddygood pushed a commit to teddygood/vllm that referenced this pull request Dec 16, 2025
1643661061leo pushed a commit to 1643661061leo/vllm_sihao that referenced this pull request Dec 16, 2025
weiyu0824 pushed a commit to weiyu0824/vllm that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Model Support: Qwen3 Token Classification

2 participants