Add snapshotRef parameter in ConnectEx

[xinyanw409]

Currently in ConnectEx() we hardcoding snapshotRef as empty string, which is not resonable. This pr updates ConnectEx() and adds the snapshotRef parameter.

Fix issue #11

snapshotRef:
A managed object reference to the snapshot of the virtual machine whose disks will be accessed with this connection. Specifying this property is only meaningful if the vmxSpec property in connectParams is set as well.

[lintongj]

@xinyanw409 why there is no issue in the use case of velero-plugin-for-vsphere?

[xinyanw409]

@xinyanw409 why there is no issue in the use case of velero-plugin-for-vsphere?
Specifying snapshotRef is only meaningful if the vmxSpec property in connectParams is set as well. In the use case of velero-plugin-for-vsphere we set vmxSpec as empty so there is no influence.

[lintongj]

Would you please run end-to-end test of velero-plugin-for-vsphere with your change, so that make sure no regression is introduced?

[xinyanw409]

Would you please run end-to-end test of velero-plugin-for-vsphere with your change, so that make sure no regression is introduced?

I've made astrolabe to pick the change locally and there is no compile issue. But it seems that plugin side can't pick up the change locally if there are two layers(vritual-disk/astrolabe). To run the e2e precheck I need to merge this change first.

[lintongj]

Would you please run end-to-end test of velero-plugin-for-vsphere with your change, so that make sure no regression is introduced?

I've made astrolabe to pick the change locally and there is no compile issue. But it seems that plugin side can't pick up the change locally if there are two layers(vritual-disk/astrolabe). To run the e2e precheck I need to merge this change first

plugin side should be able to pickup a pending change in virtual-disks without merging it first. BTW, I don't think you need to pick up the change locally in astrolabe as vsphere-specific code, IVD PE/PETM, has been moved to plugin. Let me know if you still have any questions.

[lintongj]

Please test it e2e and update result.