-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make the production build output compatible with v4.5 #2591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vue-router canceled.
|
WalkthroughThe tsdown build configuration for the router package is updated to explicitly specify ES2015 as the target for production builds of esmBrowser and IIFE formats, ensuring consistent ES2015 output across these production configurations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 46 46
Lines 4180 4180
Branches 1113 1113
=======================================
Hits 3815 3815
Misses 358 358
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A breaking change has occurred between v4.6 and v4.5.
Before v4.6, vue-router use rollup to build, the
rollup.config.mjsusees2015as compress target:Since version v4.6 switched to using tsdown for building, up until now the
tsdown.config.tsconfiguration file has not specified a target for the production build.As a result, the production build output of several v4.6 releases is no longer compatible with v4.5, showing noticeable inconsistencies in behavior — effectively introducing breaking changes.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.